Some Fixes #511
Some Fixes #511
Conversation
|
THANK YOU for your PR and for publishing the merged version! Although this functionality has sort-of been implemented in one of the latest vscode updates, their solution is not as elegant as this extension's, and it doesn't work for .vue files (and I suspect other frameworks might have similar issues), whereas this extension does it seamlessly. |
|
This PR is truly big. Would you split to smaller PRs, one issue linked to only one PR? |
|
It's not like I fixed those issues one by one, instead I implemented a different parser/algorithm. The old parser uses a regex to parse the file from top to bottom, which can unfortunately caused high cpu load and some other issues with multiline-start-tags and comments. I instead used a handcoded parser that starts at the current cursor position and then parses to the left and to the right to find the matching start- and end-tag. It is loosely based on the Html Parser of VSCode, which already handles things like multiline-start-tags and comments. So the different parser solved almost all the issues. Some issues like the typing-fast-issue (#36, #62) required some other solutions, but I don't think that extracting those solutions into separate PR's would be worth the effort. Also I can easier publish and update my fork when it's one version. |
|
Works great in my testing — is noticeably faster, doesn't have issues "keeping up" or stopping updating halfway through typing. |
|
hey @SimonSiefke, I found one bug during my usage related to React fragments. Given this code: return (
<BoardLayout
footer={
<>
Hello
</>
}
>
{children}
)if I add the closing tag for |
|
@grrowl Fixed! Let me know if you have any further issues. |
|
@formulahendry Please merge this PR or give @SimonSiefke access to this repo. Don't let this extension go stale. |
|
@formulahendry please keep up with this PR |
|
Awesome!!! |
|
The new extension is published: https://marketplace.visualstudio.com/items?itemName=formulahendry.auto-rename-tag Kudos to @SimonSiefke ! |
|
Finally 🚀 |
|
@SimonSiefke ROCKS! 👍 |
|
Note: it looks like those 102 linked issues in this PR are not automatically closed now this PR is not merged through GitHub UI. |
* auto-rename-tag-server (work in progress)
* fix
* fix a bug
* fix some bugs and clean code
* fix another issue
* clean up a bit
* remove note about performance issue
* still quotes problem
* fixed quote issue
* fix tests
* fix more bugs
* refactor: remove dead code
* bring back enabledlanguageids setting
* fix webpack build
* test for another issue
* clean up a bit
* clean up issues
* refactor: remove dead code
* refactor: less code and a bit faster
* fix: don't throw error on invalid code
* better error handling
* add prettier script
* test agains latest vscode and clean up tests
* update travis ci script
* update travis ci script
* try to fix ci
* chore: try to fix ci
* chore: try to fix ci
* ignore built vscode rename in playground
* remove unused file
* remove more unused files
* remove unused test cases
* chore: try to fix ci
* remove unused file
* chore: update deps
* fix: support all file schemes
* performance improvement for large files by throttling requests
* inrease test timeout because of throttling
* fix: jsx fragment with self-closing tag
* chore: update deps
* Update README.md
* fix: react bug with {{}}
|
Expecting this PR to also fix: Hopefully at some point the 454 issues can be closed! It is the season for spring cleaning after all 😄 Regarding the 454 issues, seems @SimonSiefke has managed to find a bug with GitHub. All 454 issues show that they are linked to this PR, but the PR itself only shows 102 issues linked! |
I really like this extension and figured that it probably benefits a lot of people, so I decided to fix some issues. :)
Some notable changes
You can try out this version by downloading the vsix: auto-rename-tag-0.1.1.zip
Update: Since it might take some time until this Pull Request will be merged, I published this version to the VSCode marketplace https://marketplace.visualstudio.com/items?itemName=SimonSiefke.auto-rename-tag
Fixes
Probably fixes
cc @formulahendry