Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] - Begin of a major moon phase in the moon dialog shows two different times, depending on the row #843

Closed
suntimer24 opened this issue Nov 17, 2024 · 1 comment · Fixed by #854
Labels
Milestone

Comments

@suntimer24
Copy link

Describe the bug
See title of the issue.

To Reproduce
Open the main app.
Open the moon dialog.
See the date and time for any major phase in the second row.
Tip on the actual moon pahse in the first row and go to that date and time of the moon phase you choosed in the second row.
Result: the date is identically, but time is differs.

Expected behavior
Same date and time in both rows.

Screenshots
Bug_Moondialog_001
Bug_Moondialog_002

Version Info:

  • App Version: [0.16.3]
  • Android Version: [Android 11 (LineageOS 18.1)] (there are no longer new versions of LOS available for my device)

Additional context
Notice that it shows "Waning Gibbous" instead of "Full Moon".
That is some super strange behaviour caused like this:
The power button on my device is broken, so I can not take screenshots.
But I can record a video of my screen and then make a screenshot of a part of that video while playing it.
As soon as I start the record, the app switching from displaying "Full Moon" to "Waning Gibbous".
Don't ask me why!
Anyway, nothing else is changing and the bug was noticed while I was not recording, so just ignore that is does not show "Full Moon". ;)

"Add any other information about the problem here.

@suntimer24 suntimer24 changed the title Begin of a major moon phase in the moon dialog shows two different times depindign on the row [Bug] - Begin of a major moon phase in the moon dialog shows two different times depindign on the row Nov 17, 2024
@suntimer24 suntimer24 changed the title [Bug] - Begin of a major moon phase in the moon dialog shows two different times depindign on the row [Bug] - Begin of a major moon phase in the moon dialog shows two different times, depending on the row Nov 17, 2024
@forrestguice forrestguice added this to the v0.16.4 milestone Nov 19, 2024
@forrestguice
Copy link
Owner

forrestguice commented Nov 19, 2024

I've been testing this by tapping a major phase, then View Date -> Moon, and then using the > and < controls.

The label in the first row is simply wrong, but the times given in the second row are the correct major phase dates.
After reviewing the code, it seems the first row is showing a "daily label" (as shown on main card), which doesn't get updated when stepping > or <.

I think the expected behavior is that the label changes from one minor phase to the next at the time of each major phase. e.g. from waxing to waning gibbous. Since the major phases are instants, their labels wouldn't normally be shown.

forrestguice added a commit that referenced this issue Nov 20, 2024
fixes bug where moon dialog displays the wrong phase label for a given date/time (#843)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants