JoinMarket update and improvements #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberm
commented
May 19, 2024
There was a problem hiding this comment.
Hello @erikarvstedt, could you please review these changes and let me know if they make sense to you? Thank you!
seberm
force-pushed
the
feature/joinmarket-update-and-improvements
branch
from
e11147a to
78b5a63
Compare
|
Fixups. Note that these are in order of your commits, so you can easily squash them. |
seberm
force-pushed
the
feature/joinmarket-update-and-improvements
branch
3 times, most recently
from
4e28aa1 to
0656458
Compare
Thank you for your fixups! Hopefully, I squashed them correctly :). |
This was referenced May 21, 2024
erikarvstedt
requested changes
May 22, 2024
seberm
force-pushed
the
feature/joinmarket-update-and-improvements
branch
from
0656458 to
1cbe955
Compare
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR integrates:
bond-calculator.pyscript (joinmarket: include the bond-calculator script #698)The changes are still WIP.