Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating minimum version requirements & tagged releases #14

Merged
merged 4 commits into from
Apr 27, 2022

Conversation

fshuva
Copy link
Collaborator

@fshuva fshuva commented Apr 18, 2022

Change List:

  • Updating TF version to v1.1
  • Updating IBM provider version to 1.40.1
  • Adding releases based on tags

@fshuva fshuva requested a review from Joel-Cripps April 18, 2022 22:17
provider.tf Outdated
@@ -12,6 +12,6 @@ terraform {
provider "ibm" {
region = var.region
ibmcloud_api_key = var.ibmcloud_api_key
generation = 2
# generation = 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we don't need this remove it. But if we still need to specify a generation then we should keep it and uncomment it.

@Joel-Cripps Joel-Cripps self-requested a review April 18, 2022 22:23
@fshuva fshuva requested a review from Joel-Cripps April 19, 2022 18:26
@Joel-Cripps Joel-Cripps added the enhancement New feature or request label Apr 19, 2022
@fshuva fshuva merged commit ed6e1da into main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants