Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockBuilder: extend trait generic support when the generics are themself generic #16

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

lemunozm
Copy link
Collaborator

Extends #14

For the cases where the generic parameter given to a trait is still generic.

Before: ie. MyTrait<u32>
Now: i.e. MyTrait<T::AccountId>

@lemunozm lemunozm self-assigned this Dec 13, 2023
@lemunozm lemunozm changed the title Extend trait generic support when the generics are themself generic MockBuilder extend trait generic support when the generics are themself generic Dec 13, 2023
@lemunozm lemunozm changed the title MockBuilder extend trait generic support when the generics are themself generic MockBuilder: extend trait generic support when the generics are themself generic Dec 13, 2023
@lemunozm lemunozm force-pushed the test-polkadot-v0.9.43 branch from 6be2287 to 108e551 Compare December 13, 2023 17:31
Copy link
Collaborator

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to seeing the application on Centrifuge Chain repo!

@lemunozm
Copy link
Collaborator Author

Thanks William!

@lemunozm lemunozm merged commit b88e237 into main Dec 13, 2023
5 checks passed
@lemunozm lemunozm deleted the test-polkadot-v0.9.43 branch December 13, 2023 17:39
@lemunozm
Copy link
Collaborator Author

Pushed again to all polkadot-<version> branches

lemunozm added a commit that referenced this pull request Dec 14, 2023
lemunozm added a commit that referenced this pull request Dec 14, 2023
lemunozm added a commit that referenced this pull request Dec 14, 2023
lemunozm added a commit that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants