Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: building with clang 16 #313

Merged
merged 3 commits into from
Nov 30, 2023
Merged

fix: building with clang 16 #313

merged 3 commits into from
Nov 30, 2023

Conversation

reckenrode
Copy link
Contributor

Downgrade compiler errors and apply a patch to imap to fix building with clang 16.

Closes #312.

@drupol
Copy link
Collaborator

drupol commented Nov 30, 2023

@reckenrode do you mind updating the flake.lock file within this PR ?

@reckenrode
Copy link
Contributor Author

@reckenrode do you mind updating the flake.lock file within this PR ?

I pushed another commit with the updated flake.lock.

@reckenrode
Copy link
Contributor Author

I force-pushed a fix for the evaluation errors that were happening on Linux.

@drupol
Copy link
Collaborator

drupol commented Nov 30, 2023

@reckenrode It's super, it's almost fixed! The Redis extension is causing some issues. Do you think it needs to be updated in the same way other extensions were updated?

Flake lock file updates:

• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/3f21a22b5aafefa1845dec6f4a378a8f53d8681c' (2023-11-20)
  → 'github:NixOS/nixpkgs/010c7296f3b19a58b206fdf7d68d75a5b0a09e9e' (2023-11-28)
@reckenrode
Copy link
Contributor Author

reckenrode commented Nov 30, 2023

@reckenrode It's super, it's almost fixed! The Redis extension is causing some issues. Do you think it needs to be updated in the same way other extensions were updated?

It did. I added the appropriate warning downgrades and confirmed it builds locally. I also made sure tidy and xdebug built as well. Everything in the checks should pass now.

@drupol
Copy link
Collaborator

drupol commented Nov 30, 2023

Thank you very much for your help!!!

@drupol drupol merged commit a0d4f8f into fossar:master Nov 30, 2023
21 checks passed
@reckenrode reckenrode deleted the clang16-fixes branch November 30, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many PHP builds on Darwin are failing to build
2 participants