client: Make _tr return the original promise

So that `then` handlers only fire on success and we can attach `catch` handlers to it.
fossar · Sep 11, 2020 · 35de644 · 35de644
1 parent dd8d428
commit 35de644
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/assets/js/selfoss-db.js b/assets/js/selfoss-db.js
@@ -317,21 +317,23 @@ selfoss.dbOffline = {
 
 
     _tr: function() {
-        return selfoss.db.storage.transaction
-            .apply(selfoss.db.storage, arguments)
-            .catch(function(error) {
-                selfoss.ui.showError(selfoss.ui._('error_offline_storage', [error.message]));
-                selfoss.db.storage = null;
-                selfoss.db.reloadList();
+        let promise = selfoss.db.storage.transaction.apply(selfoss.db.storage, arguments);
 
-                // If this is a QuotaExceededError, garbage collect more
-                // entries and hope it helps.
-                if (error.name === Dexie.errnames.QuotaExceeded) {
-                    selfoss.dbOffline.GCEntries(true);
-                }
+        promise.catch(function(error) {
+            selfoss.ui.showError(selfoss.ui._('error_offline_storage', [error.message]));
+            selfoss.db.storage = null;
+            selfoss.db.reloadList();
 
-                throw (error);
-            });
+            // If this is a QuotaExceededError, garbage collect more
+            // entries and hope it helps.
+            if (error.name === Dexie.errnames.QuotaExceeded) {
+                selfoss.dbOffline.GCEntries(true);
+            }
+
+            throw error;
+        });
+
+        return promise;
     },