client: Upgrade eslint

Needed to replace insecure hasOwnProperty to avoid https://eslint.org/docs/rules/no-prototype-builtins

assets/.eslintrc.json

@@ -43,6 +43,6 @@
         "jquery": true
     },
     "globals": {
-        "selfoss": {}
+        "selfoss": "writable"
     }
 }

assets/js/selfoss-db.js

@@ -513,13 +513,11 @@ selfoss.dbOffline = {
     storeStats: function(stats) {
         return selfoss.dbOffline._tr('rw', selfoss.db.storage.stats,
             function() {
-                for (var stat in stats) {
-                    if (stats.hasOwnProperty(stat)) {
-                        selfoss.db.storage.stats.put({
-                            name: stat,
-                            value: stats[stat]
-                        });
-                    }
+                for (let [name, value] of Object.entries(stats)) {
+                    selfoss.db.storage.stats.put({
+                        name,
+                        value
+                    });
                 }
             });
     },
@@ -780,15 +778,13 @@ selfoss.dbOffline = {
                 });
 
                 if (updateStats) {
-                    for (var statusName in statsDiff) {
-                        if (statsDiff.hasOwnProperty(statusName)) {
-                            selfoss.db.storage.stats.get(statusName, function(stat) {
-                                selfoss.db.storage.stats.put({
-                                    name: statusName,
-                                    value: stat.value + statsDiff[statusName]
-                                });
+                    for (let [name, value] of Object.entries(statsDiff)) {
+                        selfoss.db.storage.stats.get(name, function(stat) {
+                            selfoss.db.storage.stats.put({
+                                name,
+                                value: stat.value + value
                             });
-                        }
+                        });
                     }
                 }
             }).then(selfoss.dbOffline.refreshStats);

assets/js/selfoss-ui.js

@@ -733,27 +733,25 @@ selfoss.ui = {
 
 
     refreshOfflineCounts: function(offlineCounts) {
-        for (var ck in offlineCounts) {
-            if (offlineCounts.hasOwnProperty(ck)) {
-                var selector = '#nav-filter-' + ck;
-                if (ck == 'unread') {
-                    selector = selector + ', #nav-mobile-count';
-                }
-                var widget = $(selector);
-                var offlineWidget = $('span.offline-count', widget);
+        for (let [kind, count] of Object.entries(offlineCounts)) {
+            var selector = '#nav-filter-' + kind;
+            if (kind == 'unread') {
+                selector = selector + ', #nav-mobile-count';
+            }
+            var widget = $(selector);
+            var offlineWidget = $('span.offline-count', widget);
 
-                if (offlineCounts[ck] == 'keep') {
-                    offlineCounts[ck] = parseInt(offlineWidget.html());
-                } else {
-                    offlineWidget.html(offlineCounts[ck]);
-                }
+            if (count == 'keep') {
+                count = parseInt(offlineWidget.html());
+            } else {
+                offlineWidget.html(count);
+            }
 
-                if (parseInt($('span.count', widget).html()) !=
-                    offlineCounts[ck]) {
-                    offlineWidget.addClass('diff');
-                } else {
-                    offlineWidget.removeClass('diff');
-                }
+            if (parseInt($('span.count', widget).html()) !=
+                count) {
+                offlineWidget.addClass('diff');
+            } else {
+                offlineWidget.removeClass('diff');
             }
         }
     }

assets/package.json

@@ -13,7 +13,7 @@
     "spectrum-colorpicker": "^1.8.0"
   },
   "devDependencies": {
-    "eslint": "^5.16.0",
+    "eslint": "^6.5.1",
     "parcel-bundler": "^1.12.3",
     "parcel-plugin-static-files-copy": "^2.2.1",
     "parcel-plugin-sw-cache": "^0.3.1"