Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messages hard-coded in english in js #1000

Closed
Binnette opened this issue Nov 27, 2017 · 2 comments · Fixed by #1054
Closed

Messages hard-coded in english in js #1000

Binnette opened this issue Nov 27, 2017 · 2 comments · Fixed by #1054
Labels
i18n up for grabs
Milestone
2.19

Comments

@Binnette
Copy link
Contributor

Hi some message are hard-coded in english, so they are not translated (in french for me).
2017-11-27 23_28_30-selfoss 169

Examples of hard-coded english messages in javascript file (with code source):

-var refreshed='Sources have been refreshed'...
-selfoss.ui.showMessage(refreshed,'Reload list'...
-selfoss.ui.showError('Cannot refresh sources: '...

Possible french translation:

  • 'Les sources ont été rafraichies'
  • 'Recharger la liste'
  • 'Impossible de rafraichir les sources : ' (in french there is a white space before colon ':')
@Binnette
Copy link
Contributor Author

WOOOOWWWW issue #1000 !!! 🎉🎉🎊🎆🎈🎈

I wish selfoss a 'happy one thousand issue' WOOOTTTT !!! 😉😘

@jtojnar
Copy link
Member

jtojnar commented Nov 27, 2017

Hmm, I thought I had opened an issue for this but apparently we only have one for spout fields. This one should be easy to fix at least.

@jtojnar jtojnar added this to the 2.19 milestone Mar 9, 2018
@seanmcn seanmcn mentioned this issue Oct 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
i18n up for grabs
Projects
None yet
Milestone
2.19
Development

Successfully merging a pull request may close this issue.

Front end i18n updates seanmcn/selfoss
2 participants
@jtojnar @Binnette