Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use proper types in API #879

Closed
jtojnar opened this issue Feb 17, 2017 · 4 comments
Closed

Use proper types in API #879

jtojnar opened this issue Feb 17, 2017 · 4 comments

Comments

@jtojnar
Copy link
Member

jtojnar commented Feb 17, 2017

Booleans should be true or false, not "0" or "1". Similarly, numbers should not be transmitted as strings. Tags should be returned as a list, not a string of comma separated names.

niol added a commit to niol/selfoss that referenced this issue Mar 3, 2017
niol added a commit to niol/selfoss that referenced this issue Mar 3, 2017
niol added a commit to niol/selfoss that referenced this issue Mar 6, 2017
niol added a commit to niol/selfoss that referenced this issue Mar 6, 2017
niol added a commit to niol/selfoss that referenced this issue Mar 6, 2017
niol added a commit to niol/selfoss that referenced this issue Mar 14, 2017
niol added a commit to niol/selfoss that referenced this issue Mar 14, 2017
@niol
Copy link
Collaborator

niol commented Mar 14, 2017

Some work about this is available at https://github.com/niol/selfoss/tree/ppr/apitypes . As it seems what is wanted here is a major rework of how selfoss is driven from JS (like not returning HTML but lists for instance), I will stop there for now and let new features I want to work on drive those changes (using new endpoints).

Maybe a spec should be worked on before or some common RSS reader API be used instead.

@jtojnar
Copy link
Member Author

jtojnar commented Mar 14, 2017

I would not go as far as using JSON instead of HTML now. I meant the tags in /items endpoint used by applications.

In the future building the UI client-side from the same endpoints applications use could be possible – that is actually one of the points I investigate in álmafoss – I do not consider it to be in the scope of this issue, though.

I have sent you an invite to álmafoss private repo in case you are interested. It is still very rough draft and I will not have time to finish it until June.

@jtojnar jtojnar added this to the 2.18 milestone Mar 14, 2017
niol added a commit to niol/selfoss that referenced this issue Mar 15, 2017
@niol
Copy link
Collaborator

niol commented Mar 15, 2017

I fixed the tags in /items in my branch.
Thanks for the invite, but for now, I will use my free time for new features I want rather than rewriting the frontend and learning a new development environment.

niol added a commit to niol/selfoss that referenced this issue Jun 15, 2017
niol added a commit to niol/selfoss that referenced this issue Jun 16, 2017
niol added a commit to niol/selfoss that referenced this issue Jun 16, 2017
niol added a commit to niol/selfoss that referenced this issue Jun 22, 2017
niol added a commit to niol/selfoss that referenced this issue Jun 27, 2017
niol added a commit to niol/selfoss that referenced this issue Jun 27, 2017
niol added a commit to niol/selfoss that referenced this issue Jun 27, 2017
niol added a commit to niol/selfoss that referenced this issue Jun 27, 2017
@jtojnar jtojnar removed this from the 2.18 milestone Nov 29, 2017
niol added a commit to niol/selfoss that referenced this issue Jan 11, 2018
niol added a commit to niol/selfoss that referenced this issue Jan 11, 2018
niol added a commit to niol/selfoss that referenced this issue Jan 11, 2018
niol added a commit to niol/selfoss that referenced this issue Jan 11, 2018
niol added a commit to niol/selfoss that referenced this issue Mar 9, 2018
niol added a commit to niol/selfoss that referenced this issue Mar 9, 2018
niol added a commit to niol/selfoss that referenced this issue Mar 9, 2018
niol added a commit to niol/selfoss that referenced this issue Mar 9, 2018
jtojnar pushed a commit to niol/selfoss that referenced this issue Apr 21, 2018
jtojnar pushed a commit to niol/selfoss that referenced this issue Apr 21, 2018
niol added a commit to niol/selfoss that referenced this issue Apr 22, 2018
jtojnar pushed a commit to niol/selfoss that referenced this issue Apr 23, 2018
niol added a commit to niol/selfoss that referenced this issue Apr 23, 2018
jtojnar pushed a commit to niol/selfoss that referenced this issue Apr 23, 2018
niol added a commit to niol/selfoss that referenced this issue Apr 23, 2018
niol added a commit to niol/selfoss that referenced this issue Apr 23, 2018
jtojnar pushed a commit to niol/selfoss that referenced this issue Apr 23, 2018
@jtojnar
Copy link
Member Author

jtojnar commented May 3, 2020

Mostly fixed in #948

@jtojnar jtojnar closed this as completed May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants