Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: use JSX syntax in ui.init #1150

Merged
merged 3 commits into from
Oct 9, 2019
Merged

client: use JSX syntax in ui.init #1150

merged 3 commits into from
Oct 9, 2019

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Oct 4, 2019

This is much nicer than template strings. It will also be useful for client-side templating.

It should allow us to reuse the babel config.
Needed to replace insecure hasOwnProperty to avoid https://eslint.org/docs/rules/no-prototype-builtins
This is much nicer than template strings. It will also be useful for client-side templating.
@jtojnar jtojnar requested a review from niol October 5, 2019 14:10
@jtojnar jtojnar merged commit 02c3d76 into master Oct 9, 2019
@jtojnar jtojnar deleted the jsx-init branch February 19, 2020 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant