client: re-add styles to content #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not understand why we import some |
|
The reset.css removes styling for all elements so we would need to add most of https://github.com/ixkaito/unreset.css/blob/master/_unreset.scss. |
niol
approved these changes
Oct 4, 2020
jtojnar
force-pushed
the
css-unreset
branch
2 times, most recently
from
2ac683a to
0b644cc
Compare
Reset.css removes all styling including from elements like `<em>` or `<strong>`. Let’s reapply it in entry contents. I had to switch to SASS to be able to use scoped @import. The unreset library contains stuff we do not need (semantic layout elements) but it is still nicer than writing it from scratch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reset.css removes all styling including from elements like
<em>or<strong>. Let’s reapply it in entry contents.I had to switch to SASS to be able to use scoped @import.
The
unresetlibrary contains stuff we do not need (semantic layout elements) but it is still nicer than writing it from scratch.Alternately, we could switch to something like normalize.css and remove stuff we do not want (e.g. list styling for
<ul>in the sidebar) ourselves but that is more work and I am not sure how much sense it makes for us. https://css-tricks.com/reboot-resets-reasoning/Fixes: #1220