Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screaming snake case the example environment variables #54

Closed
wants to merge 1 commit into from

Conversation

pieterocp
Copy link
Contributor

@pieterocp pieterocp commented Jan 18, 2025

Overview

See Issue #30 for context.

Screaming snake cases the examples in the readme (as other github action environment variables do).

Checklist

[ ] If I changed code, I ran yarn build and committed resulting changes.

I only changed the readme.

[X] I added an example exercising this PRs functionality to .github/workflows/test.yml or explained why it doesn't make sense to do so.

I don't think this requires any tests, this is a documentation change really. I would also change the variable in the projects test but without changing it in the settings (which I do not have access to), this would just break the tests.

@pieterocp pieterocp requested a review from a team as a code owner January 18, 2025 16:28
@pieterocp pieterocp requested review from csasarak and removed request for a team January 18, 2025 16:28
@csasarak
Copy link
Contributor

Thanks for this, @pieterocp. Because of how our workflows are set up, the simplest way to get this merged is for me recreate a PR with my account in order for the required checks to run. I will make sure that you are credited as the commit author, however.

@pieterocp
Copy link
Contributor Author

Splendid, thank you.

I will make sure that you are credited as the commit author, however.

As long as it's done, happy days.

@pieterocp pieterocp deleted the issue-30-fix-examples branch January 23, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants