WIP: fix: brightness depends on number of active leds in the column #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unsure to see how this changes the value |
I tried to set the common anode pins with 20mA but nothing change. I'll try to scan leds with common cathode. But this may require rewriting all the animations.
fcartegnie
force-pushed
the
fix-brightness-issue
branch
from
4231e1d to
1bd2a07
Compare
|
rebased to use latest CI build script |
We can see all the leds being lit really low all the time. This issue is already existing on the release firmware, but not with all leds |
You mean ghosting/artefacts? That was another issue. But now they all were resolved by #61 so I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #48.
I tried to set the common anode pins with 20mA but nothing changed. I'll try to scan leds with common cathode. But this may require rewriting all the animations.