New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share button should be on right side in the dialog box #1419

Closed

1 of 2 tasks

ShridharGoel opened this issue Jan 5, 2019 · 1 comment · Fixed by #1422

Closed

1 of 2 tasks

Share button should be on right side in the dialog box #1419

ShridharGoel opened this issue Jan 5, 2019 · 1 comment · Fixed by #1422

Member

ShridharGoel commented Jan 5, 2019

Describe the bug
According to material design patterns, the button should be on the right instead of the left.

https://material.io/design/components/dialogs.html#actions
https://storage.googleapis.com/spec-host-backup/mio-design%2Fassets%2F1-f0bAaDXsx01ctVkxIWg5ufWVwT71ttA%2Fdialogs-actions-do-2.png

To Reproduce

Go to Dashboard.
Publish the event.
Dialog box appears.

Expected behavior
Share button should be on the right.

Also, a "Not now" button can be set to close the dialog.

Screenshots

Would you like to work on the issue?

Yes
No

Member Author

ShridharGoel commented Jan 5, 2019

@iamareebjamal Your views on the "Not now" button?

ShridharGoel mentioned this issue

fix: Move Share button to the right and add 'Not now' button #1422

Merged

3 tasks

iamareebjamal closed this as completed in #1422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment