Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move Share button to the right and add 'Not now' button #1422

Merged
merged 2 commits into from
Jan 5, 2019
Merged

fix: Move Share button to the right and add 'Not now' button #1422

merged 2 commits into from
Jan 5, 2019

Conversation

ShridharGoel
Copy link
Member

Fixes #1419

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

Now the share button appears on the right side in the dialog box and a not now button has been added which closes the dialog.

Screenshots for the change:

screenshot_2019-01-05-17-42-18-832_com eventyay organizer

@codecov
Copy link

codecov bot commented Jan 5, 2019

Codecov Report

Merging #1422 into development will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1422      +/-   ##
=================================================
- Coverage          24.32%   24.29%   -0.03%     
  Complexity           757      757              
=================================================
  Files                237      237              
  Lines               8708     8718      +10     
  Branches             352      352              
=================================================
  Hits                2118     2118              
- Misses              6507     6517      +10     
  Partials              83       83
Impacted Files Coverage Δ Complexity Δ
...r/core/event/dashboard/EventDashboardFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29e529c...1688a6c. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 32fcb1f into fossasia:development Jan 5, 2019
@ShridharGoel ShridharGoel deleted the issue-1419 branch January 5, 2019 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share button should be on right side in the dialog box
3 participants