Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show Ticket Sales in Events List #1315

Merged
merged 2 commits into from
Aug 14, 2018

Conversation

Masquerade0097
Copy link
Member

@Masquerade0097 Masquerade0097 commented Aug 7, 2018

Fixes #1151

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

  1. Showing Ticket Sales chart, revenue, payment currency in event list item along with pre existing items.

Screenshots for the change:
fffff

@codecov
Copy link

codecov bot commented Aug 7, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@0f8e339). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1315   +/-   ##
==============================================
  Coverage               ?   24.79%           
  Complexity             ?      757           
==============================================
  Files                  ?      236           
  Lines                  ?     8538           
  Branches               ?      342           
==============================================
  Hits                   ?     2117           
  Misses                 ?     6338           
  Partials               ?       83
Impacted Files Coverage Δ Complexity Δ
.../java/com/eventyay/organizer/data/event/Event.java 100% <ø> (ø) 1 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f8e339...3d039de. Read the comment docs.

@fossasia fossasia deleted a comment Aug 8, 2018
@fossasia fossasia deleted a comment Aug 8, 2018
@Masquerade0097
Copy link
Member Author

Masquerade0097 commented Aug 8, 2018

@iamareebjamal Status: The Server has bugs for endpoint users/id/events?include-event-orgadue to which it returns null for event-orga data. I have send this PR as the work from Orga App side is completed.

@Masquerade0097
Copy link
Member Author

Masquerade0097 commented Aug 12, 2018

@MishuVS What's the status of resolving the bug in server ? Please make it a priority if it isn't completed yet. That is a blocker for this PR.

@Masquerade0097
Copy link
Member Author

@iamareebjamal @MishuVS @sridharjajoo Server side bug is resolved and the PR is ready for review.

Copy link
Contributor

@dr0pdb dr0pdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's highly doubtful that event creation will work after addition of the new fields in the events model. Can you please test it ?

@Masquerade0097
Copy link
Member Author

Masquerade0097 commented Aug 14, 2018

@srv-twry The event creation is working fine.

@fossasia fossasia deleted a comment Aug 14, 2018
@fossasia fossasia deleted a comment Aug 14, 2018
@fossasia fossasia deleted a comment Aug 14, 2018
@fossasia fossasia deleted a comment Aug 14, 2018
@fossasia fossasia deleted a comment Aug 14, 2018
@fossasia fossasia deleted a comment Aug 14, 2018
@dr0pdb dr0pdb requested a review from iamareebjamal August 14, 2018 17:57
@iamareebjamal iamareebjamal merged commit 579b54f into fossasia:development Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants