Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Auto Check-in options for tickets to Event Settings #1320

Merged
merged 2 commits into from
Aug 12, 2018

Conversation

mooocer
Copy link
Member

@mooocer mooocer commented Aug 9, 2018

Fixes #974

Checklist:

  • I have checked for PMD and check-style issues (any gradle tasks are somehow not working for me)
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes: Adds auto check-in option to Event settings for each ticket

Screenshots for the change:

@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #1320 into development will decrease coverage by 0.39%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##             development    #1320     +/-   ##
================================================
- Coverage          25.19%   24.79%   -0.4%     
  Complexity           757      757             
================================================
  Files                232      236      +4     
  Lines               8403     8538    +135     
  Branches             339      342      +3     
================================================
  Hits                2117     2117             
- Misses              6203     6338    +135     
  Partials              83       83
Impacted Files Coverage Δ Complexity Δ
...ay/organizer/common/di/module/ViewModelModule.java 0% <ø> (ø) 0 <0> (ø) ⬇️
.../di/module/android/MainFragmentBuildersModule.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ava/com/eventyay/organizer/data/ticket/Ticket.java 100% <ø> (ø) 1 <0> (ø) ⬇️
.../core/settings/autocheckin/AutoCheckInAdapter.java 0% <0%> (ø) 0 <0> (?)
...re/settings/autocheckin/AutoCheckInViewHolder.java 0% <0%> (ø) 0 <0> (?)
...core/settings/autocheckin/AutoCheckInFragment.java 0% <0%> (ø) 0 <0> (?)
...organizer/core/settings/EventSettingsFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ore/settings/autocheckin/AutoCheckInViewModel.java 0% <0%> (ø) 0 <0> (?)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86ed4aa...ec08ded. Read the comment docs.

@mooocer
Copy link
Member Author

mooocer commented Aug 9, 2018

@sridharjajoo @Masquerade0097 @iamareebjamal @srv-twry Please review

private final CompositeDisposable compositeDisposable = new CompositeDisposable();

private final MutableLiveData<Boolean> progress = new MutableLiveData<>();
private final MutableLiveData<String> error = new MutableLiveData<>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use SingleEventLiveData

);
}

public MutableLiveData<List<Ticket>> getTickets() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public LiveData


</LinearLayout>


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line

@mooocer
Copy link
Member Author

mooocer commented Aug 11, 2018

@sridharjajoo I have made the changes. Kindly review.

@mooocer
Copy link
Member Author

mooocer commented Aug 12, 2018

@iamareebjamal @Masquerade0097 @srv-twry Please review

@Masquerade0097 Masquerade0097 merged commit 0f8e339 into fossasia:development Aug 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants