Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Modify update-apk script #1331

Merged
merged 2 commits into from
Sep 2, 2018
Merged

chore: Modify update-apk script #1331

merged 2 commits into from
Sep 2, 2018

Conversation

sridharjajoo
Copy link
Member

Fixes #1328

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

@codecov
Copy link

codecov bot commented Aug 15, 2018 •
edited
Loading

Codecov Report

Merging #1331 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1331   +/-   ##
==============================================
  Coverage          24.53%   24.53%           
  Complexity           757      757           
==============================================
  Files                237      237           
  Lines               8629     8629           
  Branches             349      349           
==============================================
  Hits                2117     2117           
  Misses              6429     6429           
  Partials              83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad574b...b64b8c0. Read the comment docs.

Masquerade0097
Masquerade0097 previously approved these changes Aug 17, 2018
View reviewed changes
iamareebjamal
iamareebjamal requested changes Aug 17, 2018
View reviewed changes
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in other place?

@sridharjajoo
Copy link
Member Author

Only the dev-apk name had to be changed

@iamareebjamal
Copy link
Member

This is removing the files. Where is the changing code?

@sridharjajoo
Copy link
Member Author

I missed that. I have done the changes

iamareebjamal
iamareebjamal reviewed Aug 18, 2018
View reviewed changes
scripts/update-apk.sh Outdated
@@ -18,7 +18,7 @@ cd apk
if [ "$TRAVIS_BRANCH" == "$PUBLISH_BRANCH" ]; then
/bin/rm -f *
else
/bin/rm -f app-playStore-debug.apk app-playStore-release.apk app-fdroid-debug.apk app-fdroid-release.apk
/bin/rm -f eventyay-organizer-dev-app-playStore-debug.apk eventyay-organizer-dev-app-playStore-release.apk eventyay-organizer-dev-app-fdroid-debug.apk eventyay-organizer-dev-app-fdroid-release.apk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bin/rm -f eventyay-organizer-dev-*.apk

iamareebjamal
iamareebjamal reviewed Aug 19, 2018
View reviewed changes
scripts/update-apk.sh Outdated
@@ -43,6 +43,12 @@ if [ "$TRAVIS_BRANCH" == "$PUBLISH_BRANCH" ]; then
done
fi

if [ "$TRAVIS_BRANCH" == "$DEPLOY_BRANCH" ]; then
for file in app*; do
cp $file eventyay-organizer-dev-${file%%}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mv

@sridharjajoo
Copy link
Member Author

@iamareebjamal Done the changes

iamareebjamal
iamareebjamal requested changes Aug 20, 2018
View reviewed changes
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last line will fail

@iamareebjamal
Copy link
Member

The goal of GSoC is to get permanent addition to teams in Open Source projects. It's sad to see everyone leave after the party when there is time when we need people. Although GSoC is over and it is completely up to you guys if you want to continue contributing to the project, but I believe that it would be beneficial for both you and the project if you continue to add support to it at your own pace.

This PR is open for days. Anyone up to finalize it @Masquerade0097 @sridharjajoo @MishuVS

@sridharjajoo
Copy link
Member Author

@iamareebjamal I will try to finalize it today. Can you tell me as to why would it fail so that I can make the required changes?

@iamareebjamal
Copy link
Member

The last line does not have the changed names

@sridharjajoo
Copy link
Member Author

@iamareebjamal I have done some changes. Kindly review

@Masquerade0097 Masquerade0097 merged commit 91a1415 into fossasia:development Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Masquerade0097 Masquerade0097 Masquerade0097 approved these changes

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees

@sridharjajoo sridharjajoo

Labels
ready-to-ship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sridharjajoo @iamareebjamal @Masquerade0097