Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typo in README.md #1368

Merged
merged 1 commit into from
Oct 14, 2018
Merged

fix: Typo in README.md #1368

merged 1 commit into from
Oct 14, 2018

Conversation

kush-mish
Copy link
Contributor

@kush-mish kush-mish commented Oct 13, 2018

Fixing the typing error in the Project Structure section.

Fixes #1370

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes: anf -> and

Fixing the typing error in the Project Structure section.
@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #1368 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1368   +/-   ##
==============================================
  Coverage          24.53%   24.53%           
  Complexity           757      757           
==============================================
  Files                237      237           
  Lines               8629     8629           
  Branches             349      349           
==============================================
  Hits                2117     2117           
  Misses              6429     6429           
  Partials              83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c152b6...57c81ab. Read the comment docs.

@iamareebjamal
Copy link
Member

Please follow PR template

@kush-mish
Copy link
Contributor Author

Done.
Although, I don't understand why one of the checks(Codacy/PR Quality Review) is not successful.

@iamareebjamal
Copy link
Member

Leave it be

Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You haven't mentioned an issue in the PR template

@kush-mish
Copy link
Contributor Author

I hope this does it.

@iamareebjamal
Copy link
Member

Still no issue linked in PR description. See merged PRs for reference

@iamareebjamal iamareebjamal merged commit 5994c85 into fossasia:development Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants