fix: Display correct selected item in navigation drawer #1394
Conversation
|
This will fail other things, there was a reason this check was in place |
|
Did changes accordingly. |
|
The Travis CI build is still failing. |
|
@ShridharGoel The |
|
@Masquerade0097 Fixed. |
Codecov Report
@@ Coverage Diff @@
## development #1394 +/- ##
==============================================
Coverage 24.48% 24.48%
Complexity 757 757
==============================================
Files 237 237
Lines 8647 8647
Branches 351 351
==============================================
Hits 2117 2117
Misses 6447 6447
Partials 83 83
Continue to review full report at Codecov.
|
| @@ -115,8 +115,6 @@ else if (eventId == -1) | |||
| finish(); | |||
| else { | |||
| fragmentNavigator.back(); | |||
| binding.navView.getMenu().findItem(R.id.nav_dashboard).setChecked(true); | |||
There was a problem hiding this comment.
What happens when back button is pressed from Attendees fragment. Does the Dashboard item get highlighted and title of toolbar changes to Dashboard?
There was a problem hiding this comment.
Title of toolbar is changing to Dashboard but Dashboard item is not getting highlighted. I'll fix it.
|
@ShridharGoel Please don't submit for review until everything is tested |
Fixes #1383
Checklist:
Changes:
Now the selected tab will be in Check-In whenever user is in Check-In or it's child fragments.
Screenshots for the change: