Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate organizer details form correctly #1414

Merged
merged 2 commits into from
Dec 29, 2018
Merged

fix: Validate organizer details form correctly #1414

merged 2 commits into from
Dec 29, 2018

Conversation

ShridharGoel
Copy link
Member

Fixes #1413

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

Now organizer details will be validated properly. First and last name are no longer compulsory and email is now compulsory.

@codecov
Copy link

codecov bot commented Dec 29, 2018

Codecov Report

Merging #1414 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1414   +/-   ##
==============================================
  Coverage          24.45%   24.45%           
  Complexity           757      757           
==============================================
  Files                237      237           
  Lines               8658     8658           
  Branches             351      351           
==============================================
  Hits                2117     2117           
  Misses              6458     6458           
  Partials              83       83

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f28bc5...80b27d3. Read the comment docs.

@iamareebjamal iamareebjamal merged commit 1290751 into fossasia:development Dec 29, 2018
AB261 added a commit to AB261/open-event-orga-app that referenced this pull request Dec 30, 2018
fix: Validate organizer details form correctly (fossasia#1414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants