Fixed #1441 Edit event triggers to upload image from anywhere in the layout of edit event #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1442 +/- ##
==============================================
Coverage 24.25% 24.25%
Complexity 757 757
==============================================
Files 237 237
Lines 8736 8736
Branches 356 356
==============================================
Hits 2119 2119
Misses 6533 6533
Partials 84 84
Continue to review full report at Codecov.
|
iamareebjamal
approved these changes
Jan 14, 2019
HHimanshusahni
added a commit
to HHimanshusahni/open-event-orga-app
that referenced
this pull request
Jan 16, 2019
HHimanshusahni
added a commit
to HHimanshusahni/open-event-orga-app
that referenced
this pull request
Jan 16, 2019
… layout of edit event (fossasia#1442)" This reverts commit 2869405.
Masquerade0097
pushed a commit
that referenced
this pull request
Feb 8, 2019
* Fix:IllegalArgumentException: Unsupported ISO 3166 country * fix: Edit event triggers to upload image from anywhere in the layout of edit event (#1442) * chore(deps): bump library from 1.2.4 to 1.2.5 (#1444) Bumps [library](https://github.com/Pes8/android-material-color-picker-dialog) from 1.2.4 to 1.2.5. - [Release notes](https://github.com/Pes8/android-material-color-picker-dialog/releases) - [Commits](https://github.com/Pes8/android-material-color-picker-dialog/commits) Signed-off-by: dependabot[bot] <[email protected]> * added checks to fix IllegalArgumentException * This reverts commit 2d7d87d. * Revert "fix: Edit event triggers to upload image from anywhere in the layout of edit event (#1442)" This reverts commit 2869405. * Fixed the space around symbols and removed unnecessary blank lines * Using country.equals() method to perform the check ,which fixes the exception * Made changes in the check statement * Used Utils.isEmpty() method in the check statement * Removing country.equals() whichis redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1441
Checklist:
Changes:
Upload Image option now gets trigger when we tap on the imageview of Update event and not from anywhere else in the layout.