Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update FAQ list automatically on item deletion #1475

Merged
merged 4 commits into from
Jan 31, 2019
Merged

fix: Update FAQ list automatically on item deletion #1475

merged 4 commits into from
Jan 31, 2019

Conversation

ShridharGoel
Copy link
Member

@ShridharGoel ShridharGoel commented Jan 28, 2019

Fixes #1474

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:
Now, FAQ list would auto-update when any item is deleted.

GIF for the change:
ezgif com-video-to-gif 26

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #1475 into development will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1475      +/-   ##
=================================================
+ Coverage          24.08%   24.08%   +<.01%     
  Complexity           757      757              
=================================================
  Files                237      237              
  Lines               8799     8798       -1     
  Branches             360      360              
=================================================
  Hits                2119     2119              
+ Misses              6596     6595       -1     
  Partials              84       84
Impacted Files Coverage Δ Complexity Δ
...tyay/organizer/core/faq/list/FaqListPresenter.java 60% <0%> (+0.65%) 16 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f4231...3342a52. Read the comment docs.

@iamareebjamal
Copy link
Member

You should not have to fetch them again. It should already have been deleted from the database

@ci-reporter
Copy link

ci-reporter bot commented Jan 29, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 0b77491. Here's the output:

Test Coverage
registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

1 similar comment
@ci-reporter
Copy link

ci-reporter bot commented Jan 29, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 0b77491. Here's the output:

Test Coverage
registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@ShridharGoel
Copy link
Member Author

@iamareebjamal Is this fine now?

Copy link
Member

@Masquerade0097 Masquerade0097 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamareebjamal iamareebjamal merged commit 2115004 into fossasia:development Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants