-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update FAQ list automatically on item deletion #1475
fix: Update FAQ list automatically on item deletion #1475
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1475 +/- ##
=================================================
+ Coverage 24.08% 24.08% +<.01%
Complexity 757 757
=================================================
Files 237 237
Lines 8799 8798 -1
Branches 360 360
=================================================
Hits 2119 2119
+ Misses 6596 6595 -1
Partials 84 84
Continue to review full report at Codecov.
|
You should not have to fetch them again. It should already have been deleted from the database |
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 0b77491. Here's the output:
|
1 similar comment
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 0b77491. Here's the output:
|
@iamareebjamal Is this fine now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1474
Checklist:
Changes:
Now, FAQ list would auto-update when any item is deleted.
GIF for the change: