Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate CreateTrackPresenter to ViewModel #1534

Merged
merged 6 commits into from
Mar 7, 2019
Merged

chore: Migrate CreateTrackPresenter to ViewModel #1534

merged 6 commits into from
Mar 7, 2019

Conversation

ShridharGoel
Copy link
Member

Fixes #1533

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

  • Migrated CreateTrackPresenter to ViewModel
  • Added tests for CreateTrackViewModel

@ci-reporter
Copy link

ci-reporter bot commented Mar 6, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 905730d. Here's the output:

Run Tests
registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

1 similar comment
@ci-reporter
Copy link

ci-reporter bot commented Mar 6, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 905730d. Here's the output:

Run Tests
registerResGeneratingTask is deprecated, use registerGeneratedResFolders(FileCollection)

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #1534 into development will increase coverage by 0.14%.
The diff coverage is 69.09%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1534      +/-   ##
=================================================
+ Coverage          24.16%   24.31%   +0.14%     
- Complexity           769      777       +8     
=================================================
  Files                238      238              
  Lines               8909     8924      +15     
  Branches             367      367              
=================================================
+ Hits                2153     2170      +17     
+ Misses              6672     6670       -2     
  Partials              84       84
Impacted Files Coverage Δ Complexity Δ
...ay/organizer/common/di/module/ViewModelModule.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ganizer/core/track/create/CreateTrackFragment.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...anizer/core/track/create/CreateTrackViewModel.java 88.37% <88.37%> (ø) 13 <13> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0fb63b...6fd0be1. Read the comment docs.

iamareebjamal
iamareebjamal previously approved these changes Mar 7, 2019
@iamareebjamal
Copy link
Member

Resolve conflicts

@ShridharGoel
Copy link
Member Author

Resolved.

@iamareebjamal iamareebjamal merged commit 0155350 into fossasia:development Mar 7, 2019
@ShridharGoel ShridharGoel deleted the migrate-create-track branch March 30, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants