Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent crash on clicking Scan QR FAB #1559

Merged
merged 4 commits into from
Mar 16, 2019
Merged

fix: Prevent crash on clicking Scan QR FAB #1559

merged 4 commits into from
Mar 16, 2019

Conversation

ShridharGoel
Copy link
Member

@ShridharGoel ShridharGoel commented Mar 14, 2019

Fixes #1558

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

Added check for camera permission before initializing camera source. Now app would not crash and permissions would be sought properly.

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #1559 into development will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff                @@
##             development   #1559      +/-   ##
================================================
- Coverage          24.81%   24.8%   -0.02%     
  Complexity           800     800              
================================================
  Files                238     238              
  Lines               8957    8962       +5     
  Branches             367     367              
================================================
  Hits                2223    2223              
- Misses              6650    6655       +5     
  Partials              84      84
Impacted Files Coverage Δ Complexity Δ
...organizer/core/attendee/qrscan/ScanQRActivity.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4895829...14981a7. Read the comment docs.

@ShridharGoel
Copy link
Member Author

@iamareebjamal @Masquerade0097 Please review.

@iamareebjamal iamareebjamal merged commit 08a0b1e into fossasia:development Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants