Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use CustomTabsIntent to open links #1576

Merged
merged 3 commits into from
Mar 26, 2019
Merged

feat: Use CustomTabsIntent to open links #1576

merged 3 commits into from
Mar 26, 2019

Conversation

ShridharGoel
Copy link
Member

Fixes #1565

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

Implemented CustomTabsIntent to open links instead of opening in browser.

GIF for the change:
ezgif com-video-to-gif (60)

@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #1576 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1576   +/-   ##
==============================================
  Coverage          24.83%   24.83%           
  Complexity           800      800           
==============================================
  Files                238      238           
  Lines               8952     8952           
  Branches             368      368           
==============================================
  Hits                2223     2223           
  Misses              6645     6645           
  Partials              84       84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0215c3...83a44a5. Read the comment docs.

@fossasia fossasia deleted a comment Mar 22, 2019
@fossasia fossasia deleted a comment Mar 26, 2019
@iamareebjamal iamareebjamal merged commit d3e58a5 into fossasia:development Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants