Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate OrganizerDetailPresenter to ViewModel #1588

Merged
merged 5 commits into from
Apr 4, 2019
Merged

chore: Migrate OrganizerDetailPresenter to ViewModel #1588

merged 5 commits into from
Apr 4, 2019

Conversation

ShridharGoel
Copy link
Member

Fixes #1587

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

Migrated OrganizerDetailPresenter to ViewModel.
Added unit tests for the ViewModel.

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #1588 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development    #1588   +/-   ##
==============================================
  Coverage          24.77%   24.77%           
  Complexity           800      800           
==============================================
  Files                238      238           
  Lines               8972     8972           
  Branches             376      376           
==============================================
  Hits                2223     2223           
  Misses              6663     6663           
  Partials              86       86
Impacted Files Coverage Δ Complexity Δ
...ay/organizer/common/di/module/ViewModelModule.java 0% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e03eb5e...a14227f. Read the comment docs.

@iamareebjamal iamareebjamal merged commit a5cb972 into fossasia:development Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants