Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent ClassCastException in ErrorUtils #1590

Merged
merged 3 commits into from
Mar 31, 2019
Merged

fix: Prevent ClassCastException in ErrorUtils #1590

merged 3 commits into from
Mar 31, 2019

Conversation

ShridharGoel
Copy link
Member

Fixes #1589

Checklist:

  • I have checked for PMD and check-style issues
  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.

Changes:

Added condition if (throwable instanceof HttpException)

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #1590 into development will decrease coverage by <.01%.
The diff coverage is 76.92%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1590      +/-   ##
=================================================
- Coverage          24.78%   24.77%   -0.01%     
  Complexity           800      800              
=================================================
  Files                238      238              
  Lines               8970     8972       +2     
  Branches             374      376       +2     
=================================================
  Hits                2223     2223              
  Misses              6663     6663              
- Partials              84       86       +2
Impacted Files Coverage Δ Complexity Δ
.../java/com/eventyay/organizer/utils/ErrorUtils.java 78.57% <76.92%> (-2.92%) 11 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdb9944...12e836b. Read the comment docs.

@iamareebjamal iamareebjamal merged commit e03eb5e into fossasia:development Mar 31, 2019
@ShridharGoel ShridharGoel deleted the error-utils-class-cast-exception branch June 27, 2019 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants