-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove unneeded success messages #1844
Merged
iamareebjamal
merged 3 commits into
fossasia:development
from
ShridharGoel:remove-success-msgs
Jul 29, 2019
Merged
chore: Remove unneeded success messages #1844
iamareebjamal
merged 3 commits into
fossasia:development
from
ShridharGoel:remove-success-msgs
Jul 29, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refresh Complete not removed |
ShridharGoel
force-pushed
the
remove-success-msgs
branch
from
July 28, 2019 19:37
9536c53
to
e02fac8
Compare
Updated. |
app/src/main/java/com/eventyay/organizer/core/attendee/history/CheckInHistoryView.java
Outdated
Show resolved
Hide resolved
iamareebjamal
requested changes
Jul 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onRefreshComplete should still be called.
ShridharGoel
force-pushed
the
remove-success-msgs
branch
from
July 29, 2019 13:42
9100794
to
026682e
Compare
Updated. |
app/src/main/java/com/eventyay/organizer/core/organizer/detail/OrganizerDetailViewModel.java
Outdated
Show resolved
Hide resolved
ShridharGoel
force-pushed
the
remove-success-msgs
branch
from
July 29, 2019 16:03
ec97b62
to
eb3d0f0
Compare
iamareebjamal
approved these changes
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1843
Changes:
Removed unneeded success messages like
Organizer Details Loaded Successfully
,Notifications Loaded Successfully
etc.