Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unneeded success messages #1844

Merged
merged 3 commits into from
Jul 29, 2019

Conversation

ShridharGoel
Copy link
Member

Fixes #1843

Changes:

Removed unneeded success messages like Organizer Details Loaded Successfully, Notifications Loaded Successfully etc.

@auto-label auto-label bot added the chore label Jul 28, 2019
@iamareebjamal
Copy link
Member

Refresh Complete not removed

@ShridharGoel ShridharGoel force-pushed the remove-success-msgs branch from 9536c53 to e02fac8 Compare July 28, 2019 19:37
@ShridharGoel
Copy link
Member Author

Updated.

Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onRefreshComplete should still be called.

@ShridharGoel ShridharGoel force-pushed the remove-success-msgs branch from 9100794 to 026682e Compare July 29, 2019 13:42
@ShridharGoel
Copy link
Member Author

Updated.

@ShridharGoel ShridharGoel force-pushed the remove-success-msgs branch from ec97b62 to eb3d0f0 Compare July 29, 2019 16:03
@iamareebjamal iamareebjamal merged commit 73744fb into fossasia:development Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove success messages
2 participants