Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve navigation flow #1853

Merged
merged 4 commits into from
Aug 2, 2019
Merged

chore: Improve navigation flow #1853

merged 4 commits into from
Aug 2, 2019

Conversation

ShridharGoel
Copy link
Member

@ShridharGoel ShridharGoel commented Jul 31, 2019 •
edited
Loading

Fixes #1852

GIF for the change:

Nav flow

@auto-label auto-label bot added the chore label Jul 31, 2019
@fossasia fossasia deleted a comment from ci-reporter bot Jul 31, 2019
@fossasia fossasia deleted a comment from ci-reporter bot Jul 31, 2019
@fossasia fossasia deleted a comment Jul 31, 2019
anhanh11001
anhanh11001 approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@anhanh11001 anhanh11001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. Please attach screenshots?

@ShridharGoel
Copy link
Member Author

Added GIF.

@iamareebjamal iamareebjamal merged commit 9ba016e into fossasia:development Aug 2, 2019
@ShridharGoel ShridharGoel deleted the nav-flow branch August 3, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhanh11001 anhanh11001 anhanh11001 approved these changes

@liveHarshit liveHarshit liveHarshit approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve navigation flow of the app
4 participants
@ShridharGoel @liveHarshit @anhanh11001 @iamareebjamal