Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update About The App section and rename it to 'About Us' #1904

Merged
merged 3 commits into from
Aug 19, 2019
Merged

chore: Update About The App section and rename it to 'About Us' #1904

merged 3 commits into from
Aug 19, 2019

Conversation

ShridharGoel
Copy link
Member

Fixes #1903

GIF for the change:

About Us

@auto-label auto-label bot added the chore label Aug 18, 2019
@fossasia fossasia deleted a comment from ci-reporter bot Aug 18, 2019
@fossasia fossasia deleted a comment from ci-reporter bot Aug 18, 2019
@iamareebjamal
Copy link
Member

  1. What's the increase in app size
  2. Everything is hardcoded. It should be configurable

@ShridharGoel
Copy link
Member Author

Everything is hardcoded. It should be configurable

Configurable from where?

@iamareebjamal
Copy link
Member

Package name can be queried programmatically. App name as well. Whatever cannot be coded should be configurable from build.gradle

@ShridharGoel
Copy link
Member Author

Okay

@ShridharGoel
Copy link
Member Author

What's the increase in app size

No increase.

@fossasia fossasia deleted a comment Aug 19, 2019
@fossasia fossasia deleted a comment Aug 19, 2019
@fossasia fossasia deleted a comment Aug 19, 2019
iamareebjamal
iamareebjamal reviewed Aug 19, 2019
View reviewed changes
app/build.gradle Outdated Show resolved Hide resolved
@fossasia fossasia deleted a comment from ci-reporter bot Aug 19, 2019
@fossasia fossasia deleted a comment from ci-reporter bot Aug 19, 2019
@iamareebjamal iamareebjamal merged commit 1f42d46 into fossasia:development Aug 19, 2019
@ShridharGoel ShridharGoel deleted the update-about branch August 27, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update About The App section and rename it to 'About Us'
2 participants
@ShridharGoel @iamareebjamal