feat: Voice search implemented on skills listing #2202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liveHarshit
reviewed
May 15, 2019
| intent.putExtra(RecognizerIntent.EXTRA_LANGUAGE, Locale.getDefault()) | ||
|
|
||
| if (intent.resolveActivity(packageManager) != null) { | ||
| startActivityForResult(intent, 10)//Sends the detected query to search |
liveHarshit
reviewed
May 15, 2019
| override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) { | ||
| super.onActivityResult(requestCode, resultCode, data) | ||
| when (requestCode) { | ||
| 10 -> if (resultCode == Activity.RESULT_OK && data != null) { |
There was a problem hiding this comment.
You declared it as constant, and still using directly.
| @@ -92,4 +92,7 @@ object Constant { | |||
|
|
|||
| //Visit Website Url | |||
| const val SUSI_VISIT_WEBSITE = "https://chat.susi.ai/" | |||
|
|
|||
| //Voice search request code | |||
| const val VOICE_SEARCH_REQUEST_CODE = 10 | |||
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 64ddcda. Here's the output:
|
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 7a0f279. Here's the output:
|
|
@iamareebjamal please review it |
…into atm_skill_voice_search
|
@iamareebjamal please review it |
liveHarshit
reviewed
Jun 3, 2019
| super.onActivityResult(requestCode, resultCode, data) | ||
| when (requestCode) { | ||
| VOICE_SEARCH_REQUEST_CODE -> if (resultCode == Activity.RESULT_OK && data != null) { | ||
| val result = data.getStringArrayListExtra(RecognizerIntent.EXTRA_RESULTS) |
There was a problem hiding this comment.
When and if statements can be combined
|
@iamareebjamal @liveHarshit please review it. |
liveHarshit
reviewed
Jun 6, 2019
|
|
||
| override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) { | ||
| super.onActivityResult(requestCode, resultCode, data) | ||
| if ((requestCode == VOICE_SEARCH_REQUEST_CODE) && (resultCode == Activity.RESULT_OK) && data != null) { |
liveHarshit
approved these changes
Jun 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2082
Changes:
Added voice search icon in action bar, clicking on which prompts voice search.
Screenshots for the change:
