Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Resolve skill details page contraction #2233

Merged
merged 4 commits into from
Jun 6, 2019
Merged

fix: Resolve skill details page contraction #2233

merged 4 commits into from
Jun 6, 2019

Conversation

atm1504
Copy link
Member

@atm1504 atm1504 commented May 29, 2019

Fixes #2138

Changes:
Changed the layout height to match parent and used replace instead of add

Screenshots for the change:
Screenshot 2019-05-29 at 7 34 43 PM

@auto-label auto-label bot added the fix label May 29, 2019
arundhatigupta
arundhatigupta reviewed May 29, 2019
View reviewed changes
Copy link
Member

@arundhatigupta arundhatigupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your commit message as per the commit guidelines. The commit message should be passive.

@atm1504 atm1504 changed the title fix: Skill details page contraction resolved fix: Skill details page contraction has been resolved May 29, 2019
@liveHarshit
Copy link
Member

liveHarshit commented Jun 2, 2019 •
edited
Loading

The commit message should be passive.

@atm1504 Still same. It should be Resolve skill details page contraction

@atm1504 atm1504 changed the title fix: Skill details page contraction has been resolved fix: Resolve skill details page contraction Jun 2, 2019
@atm1504
Copy link
Member Author

atm1504 commented Jun 2, 2019

@arundhati24 @iamareebjamal @batbrain7 please review it.

@atm1504
Copy link
Member Author

atm1504 commented Jun 6, 2019

@iamareebjamal please merge it.

@iamareebjamal iamareebjamal merged commit a4202d7 into fossasia:development Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batbrain7 batbrain7 batbrain7 approved these changes

@arundhatigupta arundhatigupta arundhatigupta approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When no feedbacks are posted the page is contracted
5 participants
@atm1504 @liveHarshit @batbrain7 @arundhatigupta @iamareebjamal