Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unclickable mic or send icon in chat activity #2236

Merged
merged 5 commits into from
Jun 6, 2019
Merged

fix: unclickable mic or send icon in chat activity #2236

merged 5 commits into from
Jun 6, 2019

Conversation

atm1504
Copy link
Member

@atm1504 atm1504 commented May 30, 2019 •
edited by iamareebjamal
Loading

Fixes #2207
Fixes #2094

Changes:
Changed the way of opening the chat activity from stt fragment. The mic or the send icon is now clickable in all cases.

Screenshots for the change:
ezgif com-video-to-gif

@auto-label auto-label bot added the fix label May 30, 2019
@ci-reporter
Copy link

ci-reporter bot commented May 30, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 65d5307. Here's the output:

spotless check
> Task :app:spotlessKotlin FAILED

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

1 similar comment
@ci-reporter
Copy link

ci-reporter bot commented May 30, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 65d5307. Here's the output:

spotless check
> Task :app:spotlessKotlin FAILED

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@atm1504 atm1504 changed the title fix: Fix unclickable mic or send icon in chat activity WIP: Fix unclickable mic or send icon in chat activity Jun 3, 2019
@auto-label auto-label bot removed the fix label Jun 3, 2019
@atm1504
Copy link
Member Author

atm1504 commented Jun 4, 2019

Further work on it can be done only after #2244 is solved.

@atm1504 atm1504 changed the title WIP: Fix unclickable mic or send icon in chat activity fix: Fix unclickable mic or send icon in chat activity Jun 4, 2019
@auto-label auto-label bot added the fix label Jun 4, 2019
@atm1504 atm1504 mentioned this pull request Jun 5, 2019
Closed
iamareebjamal
iamareebjamal requested changes Jun 5, 2019
View reviewed changes
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong solution

@atm1504
Copy link
Member Author

atm1504 commented Jun 5, 2019

@iamareebjamal I have found a better solution and simple which don't require restarting. Just, we need to enable the icon button, which was getting disabled. Also, I will fix the minor UI issue related to it. So, I am closing this pr, as it has many irrelevant changes and opening a new pr.

@atm1504 atm1504 closed this Jun 5, 2019
@liveHarshit
Copy link
Member

I am closing this pr, as it has many irrelevant changes and opening a new pr.

Bad habit. Learn Git well, it won't be a problem.

@atm1504 atm1504 reopened this Jun 5, 2019
atm1504 and others added 5 commits June 6, 2019 00:45
@atm1504
fix: Fixed the crash of signup page in landscape mode (#2240)
550f03e
@atm1504 @iamareebjamal
fix: Settings and menu mal function fixed (#2231)
14f1d79 
* fix: Fix settngs and menu mal-function

* chore: Update version

* fixed visibility of voice search icon in chat activity and stt fragment

* fix: Fixed the crash of signup page in landscape mode (#2240)


Co-authored-by: Areeb Jamal <[email protected]>
@atm1504
fix: Fix the bug in the try button of skill details page (#2247)
4b7556a 
* fix: Fix the bug in the try button of skill details page

* Make changes in debugging statement
@atm1504
Fix: Fix click actions of mic or send icon
3c91fa8
@atm1504
Merge branch 'development' into atm_clickable_mic
8d7b2fd
@atm1504
Copy link
Member Author

atm1504 commented Jun 5, 2019

@iamareebjamal please review it now. Commit no 3c91fa8 is the final solution. Everything else has been reverted.

@atm1504
Copy link
Member Author

atm1504 commented Jun 6, 2019

@iamareebjamal please review it.

@iamareebjamal iamareebjamal changed the title fix: Fix unclickable mic or send icon in chat activity fix: unclickable mic or send icon in chat activity Jun 6, 2019
@iamareebjamal iamareebjamal merged commit b387efe into fossasia:development Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
3 participants
@atm1504 @liveHarshit @iamareebjamal