feat: Implement remember me option in login screen #2243
Conversation
app/build.gradle
Outdated
| @@ -153,5 +153,7 @@ dependencies { | |||
| //Shimmer | |||
| implementation 'com.facebook.shimmer:shimmer:0.4.0' | |||
|
|
|||
| //Smart LOck authentication | |||
| implementation 'com.google.android.gms:play-services-auth:16.0.1' | |||
There was a problem hiding this comment.
Mention the version number in config.gradle and then use it here.
app/src/main/res/values/strings.xml
Outdated
| @@ -325,6 +325,7 @@ | |||
| <string name="content_type_static">Content Type: Static</string> | |||
|
|
|||
| <string name="custom_server">Custom Server</string> | |||
| <string name="remember_me">Remember Me </string> | |||
There was a problem hiding this comment.
Remove the space after 'Me'
|
You have placed all the code in the LoginActivity. The code follows MVP. You should not keep any logic or processing in the view. I suggest you read about MVP and update your code accordingly. |
|
And, please improve your commit messages. |
|
@arundhati24 @iamareebjamal @batbrain7 please review it |
|
Please make an fdroid build and upload here |
atm1504
changed the title
Looks like you have not yet worked on the reviews. |
There was a problem hiding this comment.
Can you please check how it is implemented in Attendee app. It will not work with f droid build. As @iamareebjamal suggested make f droid build first then work on play store services.
@liveHarshit I tested it with a fdroid build on my mobile and my friends mobile. It worked fine for both of us. |
https://forum.f-droid.org/t/avoid-google-play-services-while-using-play-apps/1756/3
|
|
@iamareebjamal @arundhati24 please review it. |
Okay, deploy it on fdroid and install from there. |
|
fdroid will not accept the app |
@atm1504 That's my point. Also discussed in -
|
|
Non open-source libraries can only be used in play store variant as mentioned above several times |
|
Ok, merging this. Please ensure the Fdroid build does not have the requirement. |
Fixes #1301
Changes:
Users can now save their login credentials using smart lock features (Credential API of google). Credentials are stored only if the user selects the remember me options. If clicked so, it auto fills the fields, next time when the user wants to log in.
Screenshots for the change:
