-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor rateskill code in viewholders #2270
chore: refactor rateskill code in viewholders #2270
Conversation
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 7a7c949. Here's the output:
|
@batbrain7 the circle ci probably failed because of heavy load in the circleci server. Just retrigger it. It will be able to build. |
@iamareebjamal I am able to successfully run the tests locally, could you please assert is triggering the CI will help ? |
I don't think so, IMO need to do changes in unit test files. |
Probably u r right. But, I faced this issue earlier and retriggering it did work out. If error lies in the unit test file, I think we should make an issue to solve it. : ) |
@batbrain7 just add or delete an unnecessary line and push it. It will automatically trigger the build. : ) |
Oh, what a great idea... 😅 |
all checks have been passed |
Fixes #2269
Changes: Added the API call at only one place which is the MessageViewHolder which is extended by other viewholders