Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor rateskill code in viewholders #2270

Merged
merged 4 commits into from
Jun 22, 2019

Conversation

batbrain7
Copy link
Member

Fixes #2269

Changes: Added the API call at only one place which is the MessageViewHolder which is extended by other viewholders

@auto-label auto-label bot added the chore label Jun 18, 2019
@batbrain7 batbrain7 requested a review from iamareebjamal June 18, 2019 18:55
@ci-reporter
Copy link

ci-reporter bot commented Jun 18, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 7a7c949. Here's the output:

Run Tests
> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


Failed build for cdd2535
spotless check
> Task :app:spotlessKotlin FAILED
Failed build for 8c8e8c4
spotless check

Failed build for 8c8e8c4
spotless check


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@atm1504
Copy link
Member

atm1504 commented Jun 20, 2019

@batbrain7 the circle ci probably failed because of heavy load in the circleci server. Just retrigger it. It will be able to build.

@batbrain7
Copy link
Member Author

@iamareebjamal I am able to successfully run the tests locally, could you please assert is triggering the CI will help ?

@liveHarshit
Copy link
Member

Just retrigger it. It will be able to build.

I don't think so, IMO need to do changes in unit test files.

@atm1504
Copy link
Member

atm1504 commented Jun 21, 2019

Just retrigger it. It will be able to build.

I don't think so, IMO need to do changes in unit test files.

Probably u r right. But, I faced this issue earlier and retriggering it did work out. If error lies in the unit test file, I think we should make an issue to solve it. : )

@atm1504
Copy link
Member

atm1504 commented Jun 21, 2019

@iamareebjamal I am able to successfully run the tests locally, could you please assert is triggering the CI will help ?

@batbrain7 just add or delete an unnecessary line and push it. It will automatically trigger the build. : )

@liveHarshit
Copy link
Member

@batbrain7 just add or delete an unnecessary line and push it. It will automatically trigger the build. : )

Oh, what a great idea... 😅

@batbrain7
Copy link
Member Author

all checks have been passed

@iamareebjamal iamareebjamal merged commit c87f1b6 into fossasia:development Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor the code in viewholders
4 participants