feat: Delete rooms in the device connect fragment #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamareebjamal please review it. |
|
PRF |
|
@liveHarshit can you please review it. : ) |
IMO alert dialog should display. |
We are approaching in the way present in google home. There no alert box is shown. So we have not used it here. |
liveHarshit
reviewed
Jul 1, 2019
app/src/main/res/values/dimens.xml
Outdated
| @@ -137,4 +138,8 @@ | |||
| <dimen name="height_minimum">2dp</dimen> | |||
| <dimen name="height_room_recycler">20dp</dimen> | |||
| <dimen name="width_room_recycler">20dp</dimen> | |||
| <dimen name="room_image_weight">1</dimen> | |||
| <dimen name="room_name_weight">4</dimen> | |||
| <dimen name="room_delete_weight">1</dimen> | |||
There was a problem hiding this comment.
No need to declare weight here, these are not dimensions.
There was a problem hiding this comment.
Updated. Please review now
liveHarshit
approved these changes
Jul 1, 2019
|
@iamareebjamal please review it now |
iamareebjamal
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2287
Changes:
User can now delete the name of the rooms he added before
Screenshots for the change:
Apk:
app-fdroid-debug.apk.zip