feat: Enhance the UI of the device card similar to google home #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Add place for manage devices * feat: add manage device page ui * remove finish
atm1504
changed the title
|
@iamareebjamal @liveHarshit please review it. |
|
The image used can be immensely improved |
@iamareebjamal u mean to I should change the image that I have used here. If so can you please suggest a better type of image. Or shall I download any non-copyright image and use here? |
|
Last option |
|
Updated image (copyright issue not present): |
|
@iamareebjamal please review it. |
mariobehling
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2294
Changes:
Screenshots for the change:
To be added
In google home:
