Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update shimmer dependency #2310

Merged
merged 3 commits into from
Jul 18, 2019
Merged

chore: Update shimmer dependency #2310

merged 3 commits into from
Jul 18, 2019

Conversation

atm1504
Copy link
Member

@atm1504 atm1504 commented Jul 18, 2019

Fixes #2309

Changes:

  • Updated the shimmer version
  • shifted the value of version to the config file

Screenshots for the change:
No relevant changes

@auto-label auto-label bot added the chore label Jul 18, 2019
@ci-reporter
Copy link

ci-reporter bot commented Jul 18, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 8fb0116. Here's the output:

Run Tests
> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

1 similar comment
@ci-reporter
Copy link

ci-reporter bot commented Jul 18, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 8fb0116. Here's the output:

Run Tests
> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!


This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@@ -620,4 +620,4 @@ class ChatActivity : AppCompatActivity(), IChatView {
Timber.d(videoId)
youtubeVid.playYoutubeVid(videoId)
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

@iamareebjamal iamareebjamal merged commit 2ab8580 into fossasia:development Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants