chore: Fix the release script #2325
Conversation
chore: Baseline master into dev
build.gradle
Outdated
|
|
||
| ext { | ||
| KEYSTORE_FILE = rootProject.file('scripts/key.jks') | ||
| CIRCLE_BUILD = System.getenv("CIRCLE") == "true" && KEYSTORE_FILE.exists() |
There was a problem hiding this comment.
Show me where does it say that CircleCI Builds have CIRCLE as an environment variable
There was a problem hiding this comment.
Changed it to CIRCLECI. This is present in the documentation.
|
You also have to run prep-key before the build. Please see the reference PR carefully |
Updated the circleci script. |
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of e2db68b. Here's the output:
|
1 similar comment
The build is failing✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of e2db68b. Here's the output:
|
|
|
||
| ext { | ||
| KEYSTORE_FILE = rootProject.file('scripts/key.jks') |
There was a problem hiding this comment.
This should have been exec/key.jks
There was a problem hiding this comment.
In the open event repo, there is a folder called exec, inside which all the files were kept. But here we have a folder named scripts, where such files are kept. So I used scripts there.
Can you please tell what's the use of the above statement.
There was a problem hiding this comment.
You are saying completely opposite things. open event repo has scripts folder and that's why scripts was used and susi has exec folder. You didn't change anything. You just copied. You should have changed this to exec
Fixes #2324
Changes:
Updated the script according to the one present in : fossasia/open-event-organizer-android#1770