Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up training configs #7

Closed
lchu6 opened this issue Feb 10, 2024 · 0 comments · Fixed by #14
Closed

Clean up training configs #7

lchu6 opened this issue Feb 10, 2024 · 0 comments · Fixed by #14
Assignees

Comments

@lchu6
Copy link
Contributor

lchu6 commented Feb 10, 2024

a list of minors around training configs that should be fixed later.

  1. this should really be > num_step rather than == num_step, as our batch_idx starts from 1 rather than 0. The current implementation would skip the required last step causing last checkpoint won't be written.
  2. we should remove cfg. here
  3. remove sharding_group_size in training configs, as we dropped the support for both SSDP and TP in the open source version.
  4. re-order training configs to a more meaning grouping.
@lchu6 lchu6 self-assigned this Feb 10, 2024
lchu6 added a commit that referenced this issue Feb 16, 2024
@lchu6 lchu6 closed this as completed in #14 Feb 16, 2024
@lchu6 lchu6 changed the title Some minors Clean up training configs Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant