switch to new meta device init method #65
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a new and improved version of model init which is more efficient.
Full details: #64
Performance on model init time (model creation + fsdp wrapping)
We have benchmarked the model init performance on 16 aws p4de nodes:
Validation test
Since unittest is hard to capture true-multi-node runs, we have ran external tests to make sure the new implementation pass validation test and yields true init. Specifically, we added the following plugin after FSDP call for testing purpose
and
check_parameters()
is defined here