chore(deps): upgrade fms-acceleration to >= 0.6 #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Johnson <[email protected]>
willmj
requested review from
anhuong,
Ssukriti,
aluu317,
fabianlim and
kmehant
as code owners
|
Thanks for making a pull request! 😃 |
willmj
changed the title
| @@ -45,7 +45,7 @@ dev = ["wheel>=0.42.0,<1.0", "packaging>=23.2,<25", "ninja>=1.11.1.1,<2.0", "sci | |||
| flash-attn = ["flash-attn>=2.5.3,<3.0"] | |||
| aim = ["aim>=3.19.0,<4.0"] | |||
| mlflow = ["mlflow"] | |||
| fms-accel = ["fms-acceleration>=0.1"] | |||
| fms-accel = ["fms-acceleration>=0.6"] | |||
There was a problem hiding this comment.
Curious to know, if by setting fms-acceleration>=0.6, updates lower limit of all the plugins to the version mentioned in this commit ?
There was a problem hiding this comment.
I think so, as they aren't explicitly set elsewhere
Signed-off-by: Will Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
With the new fms-acceleration version, need to upgrade.
Related issue number
How to verify the PR
Was the PR tested