-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foundation needs better vertical rhythm #5653
Comments
I'm currently using Compass's Vertical Rhythm module with Foundation, it works quite well. But I'd love to see a global default for margin bottom, as opposed to the current rem-calc(20) that is repeated quite a lot. |
Just as a note: as far as I can remember Foundation and Compass use the same name for two variables: $base-font-size and $base-line-height and this could lead to some confusion :) |
That just makes integration easier as the Foundation variables override the Compass ones, for example $base-font-size: $rem-base;
$base-line-height: floor( $base-font-size * 1.62 ); You can use all the Compass mixins (like $rhythm-unit: 'rem';
$font-unit: 1rem; So for example $alert-bottom-margin: rhythm(1); Will scale better than the current rem-calc(20). I even take it a step further and use it for my grid gutters like so: $column-gutter: rhythm(1); This is why I'd like to see some kind of base spacing variables to Foundation, for example: $base-spacing: rem-calc(20);
$base-spacing-half: $base-spacing / 2;
$base-spacing-double: $base-spacing * 2;
$base-spacing-quarter: $base-spacing / 4; |
I like it! We'll add it to the list of priorities for now, but i'm down if you'd like to do a PR on that @andy-saint |
suggestion: why not use a font-size resizable accordingly to the screen resolution as in cardinal.css? |
Closing this and adding it to our Foundation 6 wishlist: #4710 |
It doesn't seems to be implemented, but all tickets for Vertical Rhythm is closed. Or I'm wrong? I want try to use http://matejlatin.github.io/Gutenberg/. Not sure if Gutenberg and Foundation will make good friends. |
For future googlers: open ticket for Vertical Rhythm is #8164 |
Also, see #8507, where I mention how vertical rhythm is important, but following it to the pixel isn’t. |
@andycochran is link to tweet suppose to make your argument stronger? |
@stereobooster Sorry if I sounded argumentative; I didn't mean to be. I agree we should clean up the messy vertical rhythm of Foundation. Just wanted to point out that pixel perfection isn't something we should be striving for. We should instead be structuring the components to account for consistent, flexible, responsive vertical relationships. |
This applies to both typography and components in general. Vertical spacing should be based on a single variable, and consistent fractions/multiples of that variable.
The text was updated successfully, but these errors were encountered: