-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive top bar has issues with $global-flexbox: true #8325
Comments
I also have an issue involving the topbar and $global-flexbox: true. When I change $global-flexbox from false to true, running sass task (grunt) print the following error in my terminal :
Maybe that is related to @gremmie 's problem? Regards. |
Confirmed and seeing the same issue after upgrading from 6.1 to 6.2. |
I managed to fix this by renaming the default I don't know why it fixes the issue however, presumably there is a bug in the default foundation settings? |
Unfortunately this is getting pushed out to 6.3.1 |
Fix foundation#8325. See also: foundation#8779. Thanks to @natewiebe13. `.expanded` is a modifier for a horizontal menu, and should not be applied on a vertical one. Changes: - Move the `.expanded` modifier after `.horizontal` and before `.vertical`. - Add the `.expanded` modifiers for each breakpoint with the corresponding prefixes. Note: The `.expanded` modifier should be applied only when the menu is horizontal. For example, on a menu which is made horizontal on the medium breakpoint, `.medium-expanded` should be used : `.menu.vertical.medium-horizontal.medium-expanded`.
Fix foundation#8325. See also: foundation#8779. Thanks to @natewiebe13. `.expanded` is a modifier for a horizontal menu, and should not be applied on a vertical one. Changes: - Move the `.expanded` modifier after `.horizontal` and before `.vertical`. - Add the `.expanded` modifiers for each breakpoint with the corresponding prefixes. Other changes: - Use `-zf-each-breakpoint` to generate responsive modifiers. Note: The `.expanded` modifier should be applied only when the menu is horizontal. For example, on a menu which is made horizontal on the medium breakpoint, `.medium-expanded` should be used : `.menu.vertical.medium-horizontal.medium-expanded`.
Fix foundation#8325. See also: foundation#8779. Thanks to @natewiebe13. `.expanded` is a modifier for a horizontal menu, and should not be applied on a vertical one. Changes: - Move the `.expanded` modifier after `.horizontal` and before `.vertical`. - Add the `.expanded` modifiers for each breakpoint with the corresponding prefixes. Other changes: - Use `-zf-each-breakpoint` to generate responsive modifiers. Note: The `.expanded` modifier should be applied only when the menu is horizontal. For example, on a menu which is made horizontal on the medium breakpoint, `.medium-expanded` should be used : `.menu.vertical.medium-horizontal.medium-expanded`.
Fix foundation#8325. See also: foundation#8779. Thanks to @natewiebe13. `.expanded` is a modifier for a horizontal menu, and should not be applied on a vertical one. Changes: - Move the `.expanded` modifier after `.horizontal` and before `.vertical`. - Add the `.expanded` modifiers for each breakpoint with the corresponding prefixes. Other changes: - Use `-zf-each-breakpoint` to generate responsive modifiers. Note: The `.expanded` modifier should be applied only when the menu is horizontal. For example, on a menu which is made horizontal on the medium breakpoint, `.medium-expanded` should be used : `.menu.vertical.medium-horizontal.medium-expanded`.
How can we reproduce this bug?
Note: Using Foundation 6.2
$global-flexbox: true;
What did you expect to happen?
What happened instead?
Changing
$global-flexbox: false;
fixes these 2 issues.Thanks.
The text was updated successfully, but these errors were encountered: