Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsp: freescale: cairo: fix compatibility with 1.16 #1438

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

MrCry0
Copy link
Contributor

@MrCry0 MrCry0 commented Apr 6, 2024

The commit [1] breaks compatibility with cairo < 1.18. LmP is still based on OE kirkstone, that uses cairo 1.16. Return back compatibility.

[1]
commit 0e478bde ("cairo: Drop the removed packageconfigs")

@MrCry0 MrCry0 requested review from quaresmajose, ricardosalveti and a team April 6, 2024 13:32
@MrCry0 MrCry0 force-pushed the main-freescale-master-fixes branch from 7222775 to 2ce4640 Compare April 6, 2024 13:34
@MrCry0 MrCry0 changed the title bsp: freescale: cairo: fix compatibiility with 1.16 bsp: freescale: cairo: fix compatibility with 1.16 Apr 6, 2024
@quaresmajose
Copy link
Member

Have this bbappend version specific to only be valid on version 1.16 is better in my opinion, so we don't forget to drop it when we switch to the 1.18

The commit [1] breaks compatibility with cairo < 1.18. LmP is still
based on OE kirkstone, that uses cairo 1.16. Return back
compatibility.

[1]
commit 0e478bde ("cairo: Drop the removed packageconfigs")

Signed-off-by: Oleksandr Suvorov <[email protected]>
@MrCry0
Copy link
Contributor Author

MrCry0 commented Apr 6, 2024

Have this bbappend version specific to only be valid on version 1.16 is better in my opinion, so we don't forget to drop it when we switch to the 1.18

@quaresmajose you're completely right, we have no other custom settings for cairo for now.

The PR is updated.

@MrCry0 MrCry0 force-pushed the main-freescale-master-fixes branch from 2ce4640 to 47220ab Compare April 6, 2024 14:41
@MrCry0 MrCry0 merged commit 172dd68 into foundriesio:main Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants