fix(verify): improve etherscan section parsing #4574
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #3861
Closes #4571
closes #4563
This includes a fix that gives the
etherscan_api_key
of the config precedence over the chain. This is sound because, if --etherscan-api-key is provided via CLI it should be prefered over the etherscan table.This also improves the error message instead of
ETHERSCAN_API_KEY
not found.ptal @DaniPopes
Solution