Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(verify): improve etherscan section parsing #4574

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Mar 16, 2023

Motivation

closes #3861
Closes #4571
closes #4563

This includes a fix that gives the etherscan_api_key of the config precedence over the chain. This is sound because, if --etherscan-api-key is provided via CLI it should be prefered over the etherscan table.

This also improves the error message instead of ETHERSCAN_API_KEY not found.

Failed to resolve env var `BSC_ETHERSCAN_API_KEY` in `${BSC_ETHERSCAN_API_KEY}`: environment variable not found

Context:
- environment variable not found

ptal @DaniPopes

Solution

@mattsse mattsse added T-bug Type: bug Cmd-forge-verify Command: forge verify-contract/check labels Mar 16, 2023
@mattsse mattsse merged commit 97f070f into foundry-rs:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cmd-forge-verify Command: forge verify-contract/check T-bug Type: bug
Projects
None yet
1 participant