Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #6489

Closed
wants to merge 1 commit into from
Closed

Update README.md #6489

wants to merge 1 commit into from

Conversation

oxbau
Copy link

@oxbau oxbau commented Dec 1, 2023

Hi, I identified some points in this section and made changes accordingly. These are:

1. In the sentence "Configurations can be arbitrarily namespaced by profiles," it should be "Configurations can be arbitrarily namespaced with profiles".

2. In the sentence "Foundry's default config is also named default, but can arbitrarily name and configure profiles," it should be "Foundry's default config is also named default, but you can arbitrarily name and configure profiles".

3. In the sentence "Values are parsed as loose form of TOML syntax," it should be "Values are parsed as a loose form of TOML syntax".

Motivation

Solution

Hi, I identified some points in this section and made changes accordingly. These are:

    1. In the sentence "Configurations can be arbitrarily namespaced by profiles," it should be "Configurations can be arbitrarily namespaced with profiles".

    2. In the sentence "Foundry's default config is also named default, but can arbitrarily name and configure profiles," it should be "Foundry's default config is also named default, but you can arbitrarily name and configure profiles".

    3. In the sentence "Values are parsed as loose form of TOML syntax," it should be "Values are parsed as a loose form of TOML syntax".
@mattsse mattsse mentioned this pull request Dec 1, 2023
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tysm for this!

I made some improvements here #6490

@mattsse mattsse closed this Dec 1, 2023
@oxbau oxbau deleted the patch-1 branch December 1, 2023 18:35
@oxbau
Copy link
Author

oxbau commented Dec 2, 2023

Hey Mattsse, you made some improvemets in repo but didnt accept my pr. Why is it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants