Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chisel): determine proper path to Vm.sol based on proj remappings #9703

Merged
merged 1 commit into from
Jan 19, 2025
Merged

feat(chisel): determine proper path to Vm.sol based on proj remappings #9703

merged 1 commit into from
Jan 19, 2025

Conversation

grandizzy
Copy link
Collaborator

Motivation

closes #9647

  • check if in foundry project / any forge-std remapping and search proper path to Vm.sol

Solution

@grandizzy grandizzy added T-feature Type: feature C-chisel Command: chisel labels Jan 17, 2025
@grandizzy grandizzy marked this pull request as ready for review January 17, 2025 12:48
yash-atreya
yash-atreya approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@yash-atreya yash-atreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@grandizzy grandizzy merged commit 18cb6f9 into foundry-rs:master Jan 19, 2025
22 checks passed
@grandizzy grandizzy deleted the issue-9647 branch January 19, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash-atreya yash-atreya yash-atreya approved these changes

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Assignees
No one assigned
Labels
C-chisel Command: chisel T-feature Type: feature
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(chisel): support custom remappings
2 participants
@grandizzy @yash-atreya